Float type validateValue not check not a number.

OpenUI5 version: 1.50

URL (minimal example if possible): http://plnkr.co/edit/ahS6NlUHHL0kdvdddvgd?p=preview

Steps to reproduce the problem:

1. Input --0.1

• What is the expected result? Remove focus, error message will show in input, validateValue should throw an error

• What happens instead? validateValue did not throw an error. Instead, in onContinue, oBinding.getType().validateValue(oInput.getValue()) returned undefined, it should not pass validate. But if I input 200, oBinding.getType().validateValue(oInput.getValue()) will throw an error

In Float.prototype.validateValue, there seems not check for isNumber: https://github.com/SAP/openui5/blob/3a212d2b66e7935986b5507c5f520c99ec645497/src/sap.ui.core/src/sap/ui/model/type/Float.js#L87

[goligo]

Hello TinaC,

works as expected. validateValue is meant to validate the constraints on float values, it doesn’t need to be able to handle strings. When entering a string which does not represent a valid float number parseValue will throw an error.

So whenever a value is entered, first parseValue is called to convert the string value into a number. Only if parsing was successful, validateValue will be called with the result.

Regards, Malte

[TinaC]

Hi Malte,

1. I just make some changes to official custom input type: https://sapui5.hana.ondemand.com/#/sample/sap.m.sample.InputChecked/preview validateValue is used to make my custom validate rule for this type.

2. I did not use parseValue, just add it in case there is an error for parseValue not found.

3. So here comes to my question: ui5 just check the float value is within boundary conditions, but missing the check for the value is a float/number

Regards, Tina