Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Roadmap for Static Type Hints in Low-level Algorithms

See original GitHub issue

Will scikit-learn accept pull requests for low-level code with static type hints? Does it ever plan to?

I don’t know where the core team stands on static type hints in Python, but I think they make it 10x easier to grok code and convert users to contributors.

2018 seems like a great time to make this change, in light of Numpy dropping support for new features in Python 2.7. https://github.com/scikit-learn/scikit-learn/issues/11115

Supported version would need to change from Python (>= 2.7 or >= 3.4) to Python (>= 3.5) to support static type hints.

Issue Analytics

State:
Created 5 years ago
Reactions:4
Comments:11 (9 by maintainers)

Top GitHub Comments

1reaction

jnothmancommented, May 21, 2019

I think type annotations for class parameters would be helpful.

0reactions

NicolasHugcommented, Aug 30, 2020

closing as duplicate of https://github.com/scikit-learn/scikit-learn/issues/16705 which was updated more recently

Top Results From Across the Web

A hands-on introduction to static code analysis - DeepSource

An example-rich description of the architecture of static code analysis systems along with a hands-on tutorial on how to implement it.

Code Better With Type Hints - Part 1 - PyBites

In this first part I will give a short introduction to type hints, comparing the two concepts of static typing versus dynamic typing, ......

Python 3.10: Cool New Features for You to Try

Using structural pattern matching to work with data structures; Adding more readable and more specific type hints; Checking the length of sequences when...

migration_guide - OpenSSL

migration_guide - OpenSSL migration guide ... to work across all algorithm types. The "low level" APIs are targeted at a specific algorithm implementation....

System Design Netflix - A Complete Architecture

The data is shared across the cluster within the same zone and multiple copies of the cache are stored in sharded nodes. Every...