Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Default chords no longer work

See original GitHub issue

In mode.js, the defaults (in particular the root) are set after checking the regex stuff on root. So just calling ~~scribble.modes()~~ scribble.mode() throws an error at line 16 because you assume there’s always going to be a string in the first argument you can do a match on, but it looks like undefined should mean 'c'.

You also assert that the second argument must be a string that exists in modes before you assign a default.

Issue Analytics

State:
Created 6 years ago
Comments:8

Top GitHub Comments

3reactions

Zunawecommented, Jul 21, 2017

No problem! I’ve been having a lot of fun with this. Youtube recommended your SFNode presentation a few days ago and I’ve been sharing that around a bit. Keep it up!

0reactions

walmikcommented, Jul 19, 2017

Thank you so much for going through the code and the commits to unearth this!

Top Results From Across the Web

Wasting My Time Default Chords and Lyrics for Guitar - Chordie

Wasting My Time Default. 2001. Submitted by: paramore_fans@yahoo.com. Key: D. Tuning: Standard EADGBe. Chords used: D - xx0232. G - 320033. Bm -...

Why is my song not displaying the correct key? - OnSong

By default, OnSong uses the first chord of the song to determine the key. While this may not be the most accurate way...

Change and transition dataset in chord diagram with D3

The default chord generator expects data of the form created by the ... If any elements from the previous diagram no longer have...

Release info - ChordPro

There are no 'built-in' tunings and chords, just defaults. Available instrument configs are guitar, guitar-ly, mandolin-ly, and ukulele-ly. Default is guitar.

What is the musical function of broken chords?

Broken chords — playing each note of the chord one after the other — allows the chord to serve a more clearly melodic...