question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Deprecated LOM method in max.ts

See original GitHub issue

Hello @walmik,

I believe there is a deprecated method in max.ts file. Anytime I load a device that uses scribble.max method in Live 11, it throws this message:

live 11 update of max things

I think that the 'remove_notes' method in max.ts should be changed to 'remove_notes_extended', since the LOM documentation sais the following:

“Deprecated since Live 11.0. Please use remove_notes_extended instead. If a device uses the deprecated method in Live 11, a warning pop-up will notify users that the device needs to be updated.”

Simply replacing the method is not backwards compatible with Live 10, so I wrote the following 2 lines:

const live = new LiveAPI('live_app');
live.call('get_major_version') === 10 ? liveObject.call('remove_notes', 0, 1, 258, 127) : liveObject.call('remove_notes_extended', 1, 127, 0, 258);

I would have opened a PR, but I have very little experience writing TS, so Im posting it here. I have tested the solution manually with js object in Max and ES15 syntax. Im posting the ES15 code for posterity:

var live = new LiveAPI('live_app');;
if (live.call('get_major_version') === 10) {
  liveObject.call('remove_notes', 0, 1, 258, 127);
} else {
  liveObject.call('remove_notes_extended', 1, 127, 0, 258);
}

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:8 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
walmikcommented, Jun 30, 2021

wow this is a great find, thank you for noting it here… i havent moved to 11. i ll get this in soon(ish) i have begun some refactoring and documentation work. I ll pick this up.

0reactions
walmikcommented, Jul 13, 2021

Thank you @JanZaion I think this is the right way forward. I ll take a look at the PR in scribbleformax and will continue this discussion there.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Laminated Object Manufacturing of Ceramic‐Based Materials
In the LOM process, layers can be either first laminated and then cut, allowing for a less error-prone parts production and for the...
Read more >
iDRAC 8/7 v2.81.81.81 RACADM CLI Guide - Dell
List of deprecated sub-commands. ○ List of legacy groups and objects with the equivalent new groups and objects. Topics: •. New in this...
Read more >
ADC / NetScaler - Carl Stalhood
This is the easiest method of managing ADC appliances in multiple datacenters. ... Use LCD, LOM, serial cable, or 0/1 Ethernet crossover to...
Read more >
Material Code Listing
001 AGGREGATES. 100 BITUMINOUS MATERIALS. 175 BITUMINOUS MIXTURES. 200 CASTINGS {IRON & STEEL FRAMES, GRATES & {LIDS}. 215 CONCRETE MIXTURES.
Read more >
Language Subtag Registry - IANA
... language Subtag: in Description: Indonesian Added: 2005-10-16 Deprecated: ... Suppress-Script: Latn %% Type: language Subtag: ts Description: Tsonga ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found