question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Browser autocomplete triggering on SearchableDropdown

See original GitHub issue

Which package is this issue related to?

ffe-searchable-dropdown-react

Describe your issue (screenshots welcome!)

SearchableDropdown gets autocomplete-list if the field has been submitted before.

screenshot-1

What is the expected behavior?

On this component, autocomplete breaks the layout, and is not expected to show up.

Fix suggestion

I’ll make a PR where autoComplete is introduced as a prop on the contained <InputField>, and set to “off” in the <SearchableDropdown> component.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
ivarnicommented, Jun 14, 2018

Although one could argue that this component shouldn’t have autocomplete enabled ever, due to its nature. In that case, we don’t need an API prop for it at all.

I think the ideal solution is to just disable autocomplete by default and introducing the rest-pass-on described in CONTRIBUTING.md linked above.

1reaction
selbekkcommented, Jun 14, 2018

The officially documented render props` technique is nice and all - but not the appropriate approach here. We don’t ever want autocomplete on a searchable dropdown, because we implement our own “autocomplete” in a way. Therefore I suggest we follow your third recommendation, and just turn off autocomplete on the input field. Easy fix!

Read more comments on GitHub >

github_iconTop Results From Across the Web

jquery autocomplete trigger dropdown on input:focus
I've tried to trigger the focus event for the input field but that doesn't work. I somehow need to manually call the autocomplete...
Read more >
Display AutoComplete Drop down List on Focus using jQuery
Triggering an AutoComplete function to show a dropdown list using jQuery focus event is simple. This feature becomes a necessity when you come...
Read more >
Allow disabling of browser autocomplete · Issue #269 - GitHub
Actual behaviour. right now the search results has double dropdown. One by the browser autocomplete, and one by the ng-select. looks wierd.
Read more >
Javascript Autocomplete Dropdown - YouTube
In a high performing user friendly website, we use the autocomplete feature to give the user the ability to search on a list...
Read more >
HTML input autocomplete Attribute - W3Schools
The autocomplete attribute specifies whether or not an input field should have autocomplete enabled. Autocomplete allows the browser to predict the value. When ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found