Take a look at background colors in ffe-grid
See original GitHub issueWhich package is this issue related to?
ffe-grid
, ffe-grid-react
Describe your issue (screenshots welcome!)
The designguide defines a series of colours that can be used as backgrounds, namely
ffe-white ffe-grey-warm ffe-sand ffe-green-mint ffe-blue-pale ffe-orange-salmon ffe-red
and
ffe-blue-sky ffe-blue-pale ffe-blue-ice
The grid supports the following
ffe-blue-cobalt ffe-blue-ice ffe-blue-pale ffe-blue-royal ffe-green-mint ffe-grey-cloud ffe-purple-magenta ffe-sand
Some of those we support do not belong, some of those that belong we do not support
To sum up:
These should possibly be removed:
ffe-blue-cobalt ffe-blue-royal ffe-purple-magenta
These should be added:
ffe-grey-warm ffe-orange-salmon ffe-red ffe-blue-sky
I propose that we remove those that are not listed as background colours in order to discourage them being used and leave it to user-land to add those in projects where there are some kind of special reason to allow them and that we add those that are missing.
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (6 by maintainers)
Top GitHub Comments
@selbekk I was planning on mentioning it in the changelog 😃
Yes we can. That’s exactly what we do if we drop the FFE support for it. They can still use their own CSS if they really really really want to do it. If want to we discourage doing something then not making it too easy to do is a really good way to signal that in my opinion.