question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Take a look at background colors in ffe-grid

See original GitHub issue

Which package is this issue related to?

ffe-grid, ffe-grid-react

Describe your issue (screenshots welcome!)

The designguide defines a series of colours that can be used as backgrounds, namely

ffe-white ffe-grey-warm ffe-sand ffe-green-mint ffe-blue-pale ffe-orange-salmon ffe-red

and

ffe-blue-sky ffe-blue-pale ffe-blue-ice

The grid supports the following

ffe-blue-cobalt ffe-blue-ice ffe-blue-pale ffe-blue-royal ffe-green-mint ffe-grey-cloud ffe-purple-magenta ffe-sand

Some of those we support do not belong, some of those that belong we do not support

To sum up:

These should possibly be removed:

ffe-blue-cobalt ffe-blue-royal ffe-purple-magenta

These should be added:

ffe-grey-warm ffe-orange-salmon ffe-red ffe-blue-sky

I propose that we remove those that are not listed as background colours in order to discourage them being used and leave it to user-land to add those in projects where there are some kind of special reason to allow them and that we add those that are missing.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
ivarnicommented, Jun 13, 2018

@selbekk I was planning on mentioning it in the changelog 😃

1reaction
ivarnicommented, Jun 13, 2018

My point is, can we discourage things from being used but still make them available for those that need them in these edge-cases?

Yes we can. That’s exactly what we do if we drop the FFE support for it. They can still use their own CSS if they really really really want to do it. If want to we discourage doing something then not making it too easy to do is a really good way to signal that in my opinion.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Change Background Colors & Change the Color of ... - YouTube
USE LAB AND RGB COLOR AT THE SAME TIME! | Learn the quick and dirty way to change color and look at the...
Read more >
How To Change Background Color In Final Cut Pro X - YouTube
Hey there. If you're asking yourself “How to change background color in final cut pro?” you're in the right place.
Read more >
Add, change, or delete the background color in Word
Add or change the background color. Go to Design > Page Color. Choose the color you want under Theme Colors or Standard Colors....
Read more >
How to change background colors in Photoshop - Adobe
Change the background colors of your images using a variety of tools in Adobe Photoshop.
Read more >
Backgrounds and borders - Learn web development | MDN
In this lesson, we will take a look at some of the creative things you ... The background-color property defines the background color...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found