Error using base32 encoding (browser support)

Hi everybody,

I am using speakeasy in an Ember application with ember-browserify addon: https://www.npmjs.com/package/ember-browserify

Just encountered that the base32 encoding seems to not work at all. Considering the following code:

var secret = speakeasy.generateSecret(); // default length is 32
var secretKey = secret.base32;
var token = speakeasy.totp({
  secret: secretKey,
  encoding: 'base32'
});

So, just a secret generation and subsequent using it to create a new token leads to the following error:

“list” argument must be an Array of Buffers

The same issue with the speakeasy.totp.verify() method.

I’ve found the reason in the following code from index.js (lines 39-42):

// convert secret to buffer
if (!Buffer.isBuffer(secret)) {
  secret = encoding === 'base32' ? base32.decode(secret)
    : new Buffer(secret, encoding);
}

The base32.decode(secret) returns an array and not a Buffer. I’ve changed the code and got it working:

// convert secret to buffer
if (!Buffer.isBuffer(secret)) {
  secret = encoding === 'base32' ? new Buffer(base32.decode(secret)) : new Buffer(secret, encoding);
}

[Siyfion]

@mikepb & @markbao No problem, thanks for the update anyway, sometimes it’s nice just to know that the project/issue hasn’t been forgotten about and there are people “on-it”. 👍

[mikepb]

Just thought of a more permanent fix. Instead of detecting whether the base32 returns a buffer, always import the client version and have speakeasy initialize a buffer with byte array.

On Mar 2, 2017, at 1:55 AM, Simon Mansfield [e-mail] wrote:

@mikepb & @markbao No problem, thanks for the update anyway, sometimes it’s nice just to know that the project/issue hasn’t been forgotten about and there are people “on-it”. 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.