Bug: stream_delete webhook didn't work

Prerequisites

• I read the contribution guidelines
• I checked the documentation and found no answer.
• I checked existing issues and found no similar issue.
• I checked the community forum for related discussions and found no answer.
• I’m reporting the issue to the correct repository (see also speckle-server, speckle-sharp, specklepy, speckle-docs, and others)

What package are you referring to?

Backend

Describe the bug

Hi, I am developing a notification bot for Microsoft Teams using speckle-server’s webhook. I found that the stream_delete event didn’t work everytimes and it’s difficult to locate the conditions for the reproduce. Any ideas?

[gjedlicska]

We can, I’ve made the taskScheduler as part of server core. So it is reusable to trigger arbitrary callbacks.

We can do on delete set null and clean the rows periodically, where the streamId is null.

[gjedlicska]

I think i’ve found the cause of the issue here.

The rows in webhook events are deleted as the streamId deletion cascades in the DB. The webhook events table is used as a task queue for the webhook service. There are times, when we get lucky, and the tick in the webhook service fires at just the right time and the event still gets picked up.

A short term solution could be to remove the foreign key constraint from the webhooks_events table to stream.id. This would cause a buildup of event rows in the table in the long run.