test_completions_custom_path fails with jedi 0.9.0 (Spyder 3)
See original GitHub issueThe test_completions_custom_path
fails if jedi 0.9.0 is installed and succeeds with jedi 0.10.2. This test was introduced in PR #4962 by @rlaverde to fix #4410, a bug with code completion. As I understand it, the feature that the test is written for requires jedi 0.10.0 or higher. Spyder only requires jedi 0.9.0. This affects both the master
and the 3.x
branch.
One possible solution is to the test if jedi 0.9.x is installed. This is done with another test in the same PR.
Alternatively, we could require jedi 0.10.0. This would simplify our code base and ensure that everybody profits from the bug fix (the original bug seems to have taken quite some effort to be tracked down). For the record, jedi 0.10.0 was released February 2017 on PIP and May 2017 on conda.
We could also take the first approach for Spyder 3.x and the second approach for Spyder 4.x. Bumping the requirement in a minor release is perhaps too big a change in this case.
Suggestions?
Issue Analytics
- State:
- Created 6 years ago
- Comments:6 (6 by maintainers)
Top GitHub Comments
It’s passing for me locally in Python 3 and PyQt5.
I created issue #6474 so that I don’t forget about the second PR.