[Entitas:] Find alternative to pool.CreateSystem()

PoolExtension.cs contains the convenience methods pool(s).CreateSystem()

3 things:

1. CreateSystem is still the old method name from older versions, where this method actually created a system. It doesn’t anymore, instead we pass in a created system so the name is wrong.
2. It might sound misleading, because it sounds like the pool ‘owns’ the system (which it doesn’t)
3. This:

return new Feature("Systems")
            .Add(pools.CreateSystem(new IncrementTickSystem()))
            ...
            .Add(pools.core.CreateSystem(new AddViewSystem()))

Sometimes we use pools.CreateSystem(), sometimes pools.core.CreateSystem(). Would be great to streamline this.

[sschmid]

What about sth like this

.Add(new IncrementTickSystem().Bind(pools))
.Add(new AddViewSystem().Bind(pools.core))
.Add(new AddViewSystem().Bind(pools.bullet))

Bind (or a different term? Suggestions?)) actually does the same thing as CreateSystem. If a system implements ISetPoolsthen pass pools in, if it implements ISetPool then pass the pool in, if it doesn’t implement either, do nothing (same behaviour as it is right now).

This might be less confusing and more explicit. Sounds more like we’re using this system with the specified pool

[sschmid]

It’s the end of the year and a good time to clean up a little bit 😉

I updated IReactiveSystem

    public interface IReactiveSystem : ISystem {
        EntityCollector GetTrigger(Pools pools);
        void Execute(List<Entity> entities);
    }

This change enabled me to get rid of loooots of code . It’s a breaking change but I hope the result is less confusion and less code to maintain.

I deleted:

• IMultiReactiveSystem
• TriggerOnEvent
• IMatcherExtensions
• .CreateSystem()

… without loosing any features. The new IReactiveSystem can do the same as IMultiReactiveSystem and IEntityCollectorSystem

Adding systems to the list is more streamlined and less code

.Add(new IncrementTickSystem(pools))