PhoneNumberPrefixWidget, problem with 'required'

Hi,

Thanks for django-phonenumber-field

When I am using django-phonenumber-field widget with required=True , it works fine but if I change to required=False then also it is not allow to submit empty.

What I found is in class PhoneNumberPrefixWidget and in method ‘value_from_datadict’, even when there is no data it will return dot(.) and that will be raise an validation error

If I change like this, then it works

def value_from_datadict(self, data, files, name):
        values = super(PhoneNumberPrefixWidget, self).value_from_datadict(
            data, files, name)
        if all(values):
            return '%s.%s' % tuple(values)
        return ''

But if you try above code with required=True then it will throw error because there is no required message is set but this can be set on form level for now, by setting error_messages

Thanks

[archatas]

I also experienced the same problem and solved it temporarily by extending the PhoneNumberPrefixWidget and overwriting the value_from_datadict method in my code like this:

from phonenumber_field.widgets import PhoneNumberPrefixWidget as PhoneNumberPrefixWidgetBase

class PhoneNumberPrefixWidget(PhoneNumberPrefixWidgetBase):
    def value_from_datadict(self, data, files, name):
        values = super(PhoneNumberPrefixWidgetBase, self).value_from_datadict(
            data, files, name)
        if all(values):
            return '%s.%s' % tuple(values)
        return ""

[francoisfreitag]

Should be resolved with https://github.com/stefanfoulis/django-phonenumber-field/pull/512, available in the next release.