phonenumberslite fallback not working as intended
See original GitHub issue$ pip list | grep phonenumber
django-phonenumber-field (1.0.0)
phonenumbers (7.2.8)
$ grep phonenumber requirements.txt
django-phonenumber-field~=1.1.0
$ pip install -Ur requirements.txt
[...]
Installing collected packages: phonenumberslite, django-phonenumber-field
Running setup.py install for phonenumberslite ... done
Found existing installation: django-phonenumber-field 1.0.0
Uninstalling django-phonenumber-field-1.0.0:
Successfully uninstalled django-phonenumber-field-1.0.0
Successfully installed django-phonenumber-field-1.1.0 phonenumberslite-7.2.8
So the full phonenumbers was already installed, but pip ended up installing phonenumberslite anyway. And now it’s a bit of a mess, need to fix things manually (remove both phonenumberslite and phonenumbers and reinstall one of them).
Issue Analytics
- State:
- Created 7 years ago
- Comments:8 (3 by maintainers)
Top Results From Across the Web
django-phonenumber-field - PyPI
PhoneNumberInternationalFallbackWidget, a form widget that uses national numbers unless an international number is entered.
Read more >Django: undefined template variable renders as context dump
My template is using a mandatory 'title' context variable and an optional 'note' template variable. Rendering {{ title }} works fine, but ...
Read more >Flask-Security Documentation
Flask-Security allows you to quickly add common security mechanisms to your Flask application. They include: 1. Session based authentication.
Read more >python-flask-security-too(1) - Arch manual pages
These are not sufficient for a complete application - other packages are required ... Change password does not work if a user registers...
Read more >https://git.kosmos.fr/projects/KFO/repos/pretix/ra...
... 'Intended Audience :: Developers', 'Intended Audience :: Other Audience', ... https://github.com/sass/libsass/issues/3053 is fixed 'django-otp==0.7.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Probably will be better to remove
phonenumbers
/phonenumberslite
frominstall_requires
and add them inextras_require
. Then the installation to be:or
By this way anybody can set this to it’s
requirements.txt
file or just usedjango-phonenumber-field
without any extra and specify which package of phonenumbers they require.I know that
phonenumbers
is a requirement for this package to work but there will be cases that one group of users will want the lite version and the others may want full version for other reasons.What do you think about that?
P.S. Django is also a requirement but is not listed in install requires 😉
in 2.1.0 we removed the hardcoded dependecy to
phonenumbers
. Now can choose yourself which one to manually install.