Result.combine is broken for array types that are not tuple types

Since https://github.com/supermacro/neverthrow/issues/226 has been merged, Result.combine is broken for array types that are not tuple types:

import { Result } from "neverthrow";

const results: Result<string, string>[] = [];
const result = Result.combine(results); // inferred as Result<unknown, never>, but should be Result<string[], string>

Earlier, I had thought that this was actually related to the TypeScript option strictFunctionTypes, but it turns out, this is broken even with that option disabled.

Regardless, I see that neverthrow itself currently does not enable strict or strictFunctionTypes in its tsconfig.json, which is probably how this slipped through. I think in this day and age, enabling strict should be the default to ensure proper type safety, so I would recommend that neverthrow start using it, too 😃

[incetarik]

If I have free time, I think I can fix it pretty easily but I cannot promise. Until then I think the best would be using the previous version instead. As you referred one of the types as incorrectly implemented, therefore you have seen something incorrect, until the time I can come back to this, you can try fixing it or providing a solution to the problem that is marked as solved with that merge, with your own solution.

[ghost91-]

Also note that this is blocking us from upgrading neverthrow. We have currently pinned the version of neverthrow to ~5.0.0, because this issue breaks a whole lot of our code… In particular, we would not be able to upgrade in case of a security fix 😕