question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

The current master is failing in CI

See original GitHub issue

https://travis-ci.org/sweetalert2/sweetalert2-react-content/builds/390371045

./node_modules/.bin/tsc src/sweetalert2-react-content.d.ts --lib dom,es6 

src/sweetalert2-react-content.d.ts:56:37 - error TS2344: Type 'keyof T' does not satisfy the constraint 'string'.
  Type 'string | number | symbol' is not assignable to type 'string'.
    Type 'number' is not assignable to type 'string'.

56 type Overwrite<T, U> = Pick<T, Diff<keyof T, keyof U>> & U;

@toverux would you mind to take a look on this issue?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
zenflowcommented, Jun 17, 2018

@limonte Yes, I do plan to maintain this project.

Excuse for being absent: My laptop died while I was travelling in South America. It’s not an ideal place to buy a new laptop because of duties on imports, and also I’ve been doing travel things. To make matters worse I was robbed in Chile and lost my credit and debit card (making it difficult to make a large purchase).

But as of yesterday, I’m in Buenos Aires in a new apartment with my girlfriend, for the next 2.5 months, and I have a new laptop (thanks! 😃😃😃).

So I aim to resolve this tomorrow.

1reaction
limontecommented, Jun 18, 2018

I thank that TS is a must nowadays and its support is mandatory, let’s not drop it.

This issue should be fixed with https://github.com/sweetalert2/sweetalert2-react-content/pull/43

In order to fix #33 we need to either learn TS or wait for @toverux 😃 TS is in my learning roadmap, I’ll try to do it asap.

Read more comments on GitHub >

github_iconTop Results From Across the Web

CI builds fail with "does master exist?" · Issue #517 - GitHub
Initially when we started seeing this, it happened to be on a branch created from another branch. We tried rebasing onto master, and...
Read more >
How to avoid broken master with Pipelines for Merged Results ...
Broken master. This can happen when CI pipelines run on the master branch, but don't pass all tests. A red cross mark is...
Read more >
How to block the merge of Current PR if the previous CI build ...
If build failed, PR will not be completed: enter image description here. So you can not get broken code in your master branch....
Read more >
[JENKINS-33466] Current master branch fail to build
The merge of the PR772 (https://github.com/jenkinsci/job-dsl-plugin/pull/772) break the build.
Read more >
Interpreting CI Failures | Kibana Guide [master] - Elastic
To view the logs for a failed specific ciGroup, jest, type checkers, linters, etc., click on the Pipeline Steps link in from the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found