TypeScript definitions are incorrect.
See original GitHub issueonOpen
and onClose
does not take the popup as their argument, this should be updated in the definitions file.
Issue Analytics
- State:
- Created 4 years ago
- Comments:5 (4 by maintainers)
Top Results From Across the Web
How to overwrite incorrect TypeScript type definition installed ...
A way that is not mentioned here is to put a type declaration in a index.d.ts file. For my case, the types from...
Read more >Typescript definitions are incorrect for YAxis.showLastLabel
This value can be a boolean (as in version 10.2.0). Actual behaviour. At the moment I get this error: Error: src/stk-charts/configs ...
Read more >Surviving the TypeScript Ecosystem — Part 4 - Medium
One thing to remember is that the type definition files in DefinitelyTyped are community sourced. In most cases they are not written by...
Read more >Incorrect type resolution from typings in a case of multiple type ...
It looks like type is incorrectly being resolved from typings definition in a case if there is multiple type definitions are available for...
Read more >TypeScript - CustomStore - Incorrect typing definition for the ...
In our solution we created a custom store, that is reused by different components. We found the issue as we added tests for...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
After wrapping my modals in
sweetalert2-react-content
theonOpen
andonClose
functions no longer received the modals as their argument, and I had to callSwal.getPopup
to get a hold of if. So what I’m trying to say, is that this package should redefine theonOpen
andonClose
signatures to be() => void
instead ofHTMLElement => void
. Similar to what you do for the other changed props: https://github.com/sweetalert2/sweetalert2-react-content/blob/master/src/sweetalert2-react-content.d.ts#L36🎉 This issue has been resolved in version 2.0.2 🎉
The release is available on:
Your semantic-release bot 📦🚀