question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make link hints show appropriate and correct number of letters

See original GitHub issue

With this as my Vimari settings:

{
  "excludedUrls": "",
  "linkHintCharacters": "werafjkl:",
  "detectByCursorStyle": false,
  "scrollSize": 150,
  "openTabUrl": "",
  "modifier": "",
  "smoothScroll": true,
  "scrollDuration": 25,
  "bindings": {
      "hintToggle": "f",
      "newTabHintToggle": "shift+f",
      "scrollUp": "k",
      "scrollDown": "j",
      "scrollLeft": "h",
      "scrollRight": "l",
      "goToPageTop": "g g",
      "goToPageBottom": "shift+g",
      "goToFirstInput": ":",
      "goBack": "shift+j",
      "goForward": "shift+k",
      "reload": "r",
      "tabBack": "a",
      "tabForward": "w",
      "closeTab": "e",
  }
}

I often encounter a bug where a link hint that ends with a w will trigger tabForward after going to the link hint as it is supposed to do.

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:7

github_iconTop GitHub Comments

1reaction
nbelzercommented, Aug 24, 2020

I feel like filtering out the bindings is not such a great solution. It limits users to keybindings they haven’t assigned yet while we are already blocking the Vimari bindings in link-hint-mode. Perhaps we could filter out those bindings for the last character in the link hints.

So if there are more link hints needed than all 2 letter combinations. Show all for the 2 letter combos and then do remaining combos with 3 letters. Same applies for 1 and 2 letter.

Changing the link hint behaviour to work like this would require more significant changes to the link-hint code. This might be worth investigating if we cannot get a Vimium port to Safari. However for now I believe we should go with the second option (to require all characters in the hint to be typed) as this is most inline with what the user expects when presented with the link hints.

0reactions
nbelzercommented, Aug 27, 2020

While the merged PR #191 uses the suggested solution, the larger problem of incorrectly sized link hints remains.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Format URLs in Text - Quick and Dirty Tips
Today's topic is how to treat URLs when you have to use them in text. Web addresses are strange beasts; they seem more...
Read more >
Creating hyperlinks - Learn web development | MDN
This article shows the syntax required to make a link, and discusses link best practices. Prerequisites: Basic HTML familiarity, as covered in ...
Read more >
Form Letters Properly with These 9 Helpful Tips
7. Model the Correct Way to Form Letters Properly · Show children how to form the letter first (while using the appropriate verbal...
Read more >
Google URL Structure Guidelines | Documentation
A site's URL structure should be as simple as possible. Consider organizing your content so that URLs are constructed logically and in a...
Read more >
Basic Syntax - Markdown Guide
To create a heading, add number signs ( # ) in front of a word or phrase. The number of number ... Without...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found