Vimari Fork

This is mostly targeted at the maintainers of Vimari (which I believe to be @danielcompton and @simeg)

I’ve been using Vimari for quite some time now but it’s been missing some features that I and others would like to see. These include:

• Customisation (#171, #166, #155, #153, #142, #98)
• Better mode isolation (insert vs normal) (#170, #168, #148, #110, #102)
• Smooth Scrolling (#157, #83)
• A help page (#158)

Some of these features have been available in PR’s to the project for some time now which I have combined in my own version of Vimari on my own fork.

---

My fork currently includes:

• update mousetrap library
• configuration support (mostly by the work of @nieldm),
• smooth scrolling
• isolated normal mode such that issues like #168 don’t happen

Before being able to merge these changes back in to the main repo I would like to:

• implement an indicator showing when you are in insert mode.
• introduce some sort of overlay with a help page (although this could be done separately)
• cleanup of legacy code related to how the extension worked before Safari 12. There seems to be some unused code that should probably be removed.
• making sure the extension works properly on macOS Big Sur.

---

I’m wondering if there is an interest in bringing some of this functionality back to this main repo and send it out to all those using Vimari from the App Store. As I’m already putting in some of my free time on my own fork, I’d be willing to put in some extra time to bring these features back to the main repo. However since the repo has been pretty silent for some time now I’d like to discuss this before putting in the work.

I hope this is the right place to discuss this, please let me know if there is an interest in this and how we could go about it.

[danielcompton]

Hi @nbelzer, thanks for doing all this work. As you can probably tell, I haven’t had a ton of time for Vimari over the last six months due to COVID + other personal stuff. If you’d like, I’m happy to invite you as a maintainer to the repo.

Longer term, I’ve been excited to see that Safari is going to support WebExtensions. In theory this would let us unify the codebase with Vimium. I see you’re already involved in the discussion at https://github.com/philc/vimium/issues/3610.

[simeg]

Hello.

I’m not maintaining this repo any more, but it sounds great to me!

My recommendation would be to not aim for a big bang integration but make multiple small and descriptive PRs. Your code may make sense to you but for maintainers it can be hard to understand code changes if they’re grouped and lacking good commit messages. This is probably not news to anyone but I feel like it’s worth repeating 🙂