question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add setting to turn off blocks/components being auto-flagged as DEPLETABLE

See original GitHub issue

Right now, a block (or component) that is not flagged by the user as DEPLETABLE will be auto-flagged by the code as DEPLETABLE if it contains an isotope/element which has been set burn=True in its nuclideFlag. This makes it so that blocks/components that a user may not have intended to deplete will be depleted. Apparently the only way to override this behavior is to explicitly assign a flag to the block/component so that the auto-flagging capability is disabled entirely for that block/component.

I would like to propose two options to override this behavior so that blocks/components are not necessarily depleted just because they contain burnable isotopes. I understand that backwards compatibility is desired on this topic, so neither of my proposals will break that.

  1. Introduce a new flag like NONDEPLETABLE that forces a given block/component to not be depleted, no matter the isotopics. This would allow a user to turn off depletion on a block-by-block basis.
  2. Introduce a new global setting that turns off the auto-flagging for the DEPLETABLE flag such that only blocks/components with the DEPLETABLE flag are actually depleted. Leave the default behavior as is.

In my opinion, this would be very useful. Oftentimes is it useful for particular compositions to not change as others are burned. This would enable a user to accomplish this without having to assign arbitrary flags to components.

Any thoughts?

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

3reactions
bmingstcommented, Dec 7, 2021

Embedding functional information into a name field has the drawback that the name used will sometimes need to be different than the name used in the reference documents – especially if the documents are from non-English speakers. I like the idea of a setting to turn off auto-generation of flags. This would prevent unintentional flag settings based on block names and keep some backward compatibility.

2reactions
kecklercommented, Dec 7, 2021

My understanding of what @jakehader means is this – Right now ARMI will spawn flags for components/blocks/assemblies based on their names. So an assembly called fuel assembly 1 will get a FUEL flag and an assembly called primary absorber assembly 2 will get a PRIMARY flag, whereas an assembly called assembly 1 will not get any because it doesn’t have any special keywords. I think he is suggesting a way to turn that off. Correct me if I’m wrong, though.

To your Question 2 – There are a number of scenarios where one might want to turn off depletion from a given assembly, in the same way that one might not want to deplete a given isotope. For instance, most of the time I don’t want to deplete reflector assemblies or shield assemblies, or perhaps the lower/upper reflector regions of fuel assemblies. Obviously in reality they do indeed ‘deplete’, but sometimes that effect is so small that it is not worth the computational expense. Right now we have the ability to turn on/off depletion of isotopes using the NuclideFlags. But just because I want to deplete one particular isotope in a given block does not mean I want to deplete every block that also contains that single isotope.

I agree that option (2) is the better way to get this done. I might not work on this immediately, but I can take the task to work on it.

Any other thoughts?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Flag emails in Mail on iPhone - Apple Support
You can add a Flagged mailbox so all your flagged emails are easily accessible in one location. Tap the Back button in the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found