question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove references to geom files in the code

See original GitHub issue

Back in the day, we used to specify core layout in what was called a facemap or geom file. While we retain the code that supports this input mechanism (see https://github.com/terrapower/armi/blob/master/armi/reactor/systemLayoutInput.py), it is mostly there to enable the migration performed here: https://github.com/terrapower/armi/blob/190c0caccfd36a0442118a1ae666c2a20c52a4d1/armi/reactor/blueprints/__init__.py#L524

Instead we recommend using grid blueprints instead. However, when these were completely separate input files, they became part of some major ARMI function signatures where input stuff gets passed around, usually as geom. We should try to remove as many of these as we can.

Actually searching around, I’m not seeing as many as I remember (go us!), but a glaring example is in the Case class: https://github.com/terrapower/armi/blob/190c0caccfd36a0442118a1ae666c2a20c52a4d1/armi/cases/case.py#L73

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
kecklercommented, Mar 16, 2022

In fact, I would love it if XML support was dropped.

0reactions
john-sciencecommented, Dec 15, 2022

Okay, we definitely support basic RZTheta geometries in YAML format.

Nick believes there are some extra pieces of information in the RZTheta geom files that isn’t supported in RZTheta YAML files. So I need to find the specifics of what we don’t support, and build support for it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Delete Features (Data Management)—ArcGIS Pro
ArcGIS geoprocessing tool used to remove features from a feature class or ... This tool deletes both the geometry and attributes of the...
Read more >
How To Remove Unwanted Regions From Your Map Data
The task here is to remove all of the features from the dataset that you don't need ... the field references in the...
Read more >
Function reference - ggplot2
All layers have a position adjustment that resolves overlapping geoms. Override the default by using the position argument to the geom_ or stat_...
Read more >
USD Frequently Asked Questions - Pixar Graphics
How can I convert USD files between binary and text? What data types are supported? ... When can you delete a reference (or...
Read more >
Earth Engine Code Editor - Google Developers
scriptPath={repo}:{script} to share a reference to a file in your repo, e.g. https://code.earthengine.google.com/?scriptPath=users/username/utils:utils. Upon ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found