question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug in `applyInputParams` of multiple material classes

See original GitHub issue

The applyInputParams methods of multiple material classes contain a common bug when applying enrichments to particular isotopes/elements. Take, for example, adjusting the enrichment of B10 within the B4C class:

 def applyInputParams(
        self, B10_wt_frac=None, theoretical_density=None, *args, **kwargs
    ):
        if B10_wt_frac:
            # we can't just use the generic enrichment adjustment here because the
            # carbon has to change with enrich.
            self.adjustMassEnrichment(B10_wt_frac)

If the user intentionally specifies B10_wt_frac=0, as in they want their absorber to have only B11, the enrichment will not be adjusted because the conditional evaluates to False.

This same bug applies to other material classes, including UO2, and possibly others.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
john-sciencecommented, Sep 28, 2021

PR Merged! Thanks @keckler!

1reaction
kecklercommented, Sep 28, 2021

PR added at #425

Read more comments on GitHub >

github_iconTop Results From Across the Web

More than one class type for a Material - SAP Community
You can maintain different classes for same material. Go to material master and go to Classification view. Go to Extras->Change class type (F7)...
Read more >
[BUG] Multiple classes in the same file get the same description
I have a few typescript classes in a single file. I documented each one of the classes but the generated documentation uses the...
Read more >
How Do Bug Characteristics Differ Across Severity Classes
While different bug tracking systems use different severity scales, we found that bugs can be assigned into one of three severity classes: high...
Read more >
Multiple bugs in the interface - WordPress.org
There's multiple bugs in the pages created by Tutor. Some bugs in the interface (these bugs happen when the user access the class...
Read more >
Online Museum Class: Secret Life of Bugs
Dig into the secret lives of the insects that call our neighborhoods home and learn how to protect insect habitats.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found