question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Missing material modifications in docs

See original GitHub issue

There is a table in section 2.2.4 of the documentation that describes the material modifications available across all the material classes in the framework: image

This table is missing entries for the following material classes:

  • lithium
  • mox
  • uraniumOxide
  • uZr

The entries are drawn programmatically in blueprints.rst by looking at all subclasses of Material: image

The problem appears to be that it does not recursively look into all subclasses of Material. For instance, the classes above are subclassed from:

  • lithium – material.Fluid
  • mox – UraniumOxide
  • uraniumOxide – material.FuelMaterial
  • uZr – material.FuelMaterial

This piece of the documentation should be updated to draw the entries recursively.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
john-sciencecommented, Oct 5, 2021

I haven’t forgotten about this ticket. It appears that inside the if numArgs > 1: condition, we can do something like:

for subM in m.__subclasses__():

And do the same if numArgs > 1: checking again. I just haven’t decided the cleanest way to write the resultant two loops (or the final table) yet.

It’ll happen this week.

0reactions
john-sciencecommented, Oct 5, 2021

Thanks John. My only issue is that the modifications that we just deprecated in #430 are showing up in this table (i.e. theoretical_density and sulful_density_frac). I don’t really see a way around this, so I guess I’ll live with it.

Yeah, at some point we will have to move the API along, and fully deprecate those method signatures. When that happens the code (and the docs) will be cleaner.

Set your watches for deprecation day.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Find what's changed in a file - Google Docs Editors Help
On your computer, open a document, spreadsheet, or presentation. · At the top, click File and then Version history and then See version...
Read more >
Restore a past version in Google Docs - YouTube
Restore a past version in Google Docs. Learn more → https://goo.gle/2lrXt6B ...
Read more >
Google Docs How to Recover an Erased Paper or Work
Best data recovery software : https://bit.ly/3IxCapK50% off now : https://bit.ly/3rLcoZpWas the video helpful? Want to return the favor.
Read more >
Why can I not see revision history of shared Google Docs ...
If the See revision history is greyed out or you can't select it, the document you are viewing does not allow you to...
Read more >
Documentation for version 4-11.4 of material ui is missing
Since the rollout of MUI v5.0.0-rc.1 all the doc pages of v4 other than v4.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found