Messages containing emoji and colors are not fully optimized

See https://github.com/thelounge/lounge/pull/1770#discussion_r154022888

When parsing Super \x034💚 green!, result should be:

Super <span class="emoji irc-fg4">💚</span><span class="irc-fg4"> green!</span>

It is instead:

Super <span class="emoji"><span class="irc-fg4">💚</span></span><span class="irc-fg4"> green!</span>

[xPaw]

@Bonuspunkt Do you have any interest in looking into this? (and #2276)

My understanding is that merge in parse needs to be done differently because it simply wraps fragments it wants in it’s own elements (which is why emoji span ends up containing a duplicate formatting span). This is the case for all parts that generate their own HTML (emojis, links, channels, nicks).

Not sure how we would optimize this though. Remake createFragment to also accept custom data so that it can generate a single element?

And even then, it should be a little smarter than that in fragment generation, if a formatter completely wraps a link, it should just let the link sit inside the formatted element.

[xPaw]

<span class="irc-fg4"><span class="emoji">💚</span> green!</span> would also be fine by me, depending on the complexity.

@Bonuspunkt I remember this coming up before for other elements but not the reason why, do you remember why it’s not being optimized away?