Macro implementation

Following up from my post on twitter yesterday (https://twitter.com/dbonner1987/status/889252632023490564) and my adventures down the rabbit hole with the routing system in Laravel.

I’m now using just a single Route::macro implementation that will add filtering to routes. Security through obscurity is not smart but I got a bee in my bonnet and became a bit engrossed in getting a macro working cleanly.

What I have settled on for the time being is:

// Usage
Route::blacklist()->name('tags.index')->get('/tags', 'TagsController@index');

// Implementation
Route::macro('blacklist', function () {
    return new class($this) {
        protected $router;
        
        public function __construct($router)
        {
            $this->router = $router;
        }

        public function __call($method, $parameters)
        {
            call_user_func_array([$this->router, $method], $parameters);

            if ($method === 'name') {
                config()->set('ziggy.blacklist', array_merge(
                    config('ziggy.blacklist', []), [array_get($parameters, 0, null)]
                ));
            }

            return $this;
        }
    };
});

Currently this allows all methods chained on to blacklist to be in any order.

Looking for some thoughts on this implementation.

[davidianbonner]

@DanielCoulbourne Excellent, hoping to get a look at implementing it over the weekend.

[davidianbonner]

Sounds like a plan. Will get it done tomorrow – calling it a night.

Cheers.

On 3 Sep 2017, 00:44 +0100, Daniel Coulbourne [e-mail], wrote:

@dbonner1987 Could you open a PR to this repo but just add [WIP] to the name so I know it’s in progress? That way I can look over a diff and we can keep discussion inside this repo so other contributors can get involved? Thanks so much! -DC — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.