May you add support of querystring?

Hello. May you add support of querystring in route url? I mean something like this: example.com/search?critter=bunny&gender=female&temperament=rabid&size=large&color=red

[DanielCoulbourne]

Done and Done!

[DanielCoulbourne]

Okay I’m still not 100% sure.

My two favorite options so far are route('events.venues.show', [event, venue, queryStringParams]) and route('events.venues.show', [event, venue], queryStringParams)

I think your first version is fine but it is a breaking change and starts to add complexity for the most basic use-case. Basically I don’t want people who are just picking up the project to have a more complicated road to using the it.

I think the option I’m leaning to now is making route() just return a new Router(), overriding the Router.prototype.toString with all the stuff we currently have, and adding a Router.prototype.withParams or something (naming of this function is still up in the air) so we can chain params onto the existing router.

That way someone can do route('posts.show', 1).withParams({color: red})

Here’s a quick fiddle so you can see it in action.

I think this is the most Laravel way to do it. I want to abstract unnecessary complexity out into fluency so that it’s hidden if you don’t need it. Rather than making the base function super complex with tons of additional params, lets just add fluency. It sets a good pattern for the future as well when the next hot idea for a feature emerges. Otherwise 2 months from now we’ll be scratching our heads trying to figure out how we’re going to get more data into those 3 arguments.