Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Commercial product leakage to package.json

See original GitHub issue

Description of the bug

Currently commercial projects like vaadin-grid-pro are added to the package.json and package-lock.json even tho only vaadin-core is used as dependency.

Expected behavior

Not used dependencies / commercial products are NOT added into the package.json or package-lock.json.

Minimal reproducible example

Create a V23 app in start.vaadin.com
Replace vaadin dependency with vaadin-core
Delete package.json & package-lock.json
mvn
Look at the nearly created package.json containing commercial products

Versions

Vaadin / Flow version: V23 + V23.1.0.beta1 tested
Java version: 11

Issue Analytics

State:
Created a year ago
Reactions:3
Comments:7 (2 by maintainers)

Top GitHub Comments

1reaction

ZheSun88commented, Jun 20, 2022

I have created this PR to generate different json file for vaadin and vaadin-core

and the json will be included into different jars.

Platform includes free components into vaadin-core-versions.json and includes it into vaadin-core JAR
Platform includes commertial components into vaadin-versions.json and includes it into vaadin JAR

i think flow will need to do corresponding changes to make it include the correct json into the generated package.json files.

0reactions

vaadin-botcommented, Sep 7, 2022

This ticket/PR has been released with Vaadin 23.2.0.