question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Standardise on top margin for settings tabs

See original GitHub issue

Different tabs in the settings dialog currently have slightly different layouts. The layouts should follow the same style so should look more similar. An example of the correct layout in the Sidebar tab can be found here. The fix should apply margin-top: 10px to .mx_SettingsTab_section in the CSS and verify each dialog tab to make sure it’s using the CSS correctly.

The updates need to be made to these tabs (current spacing listed for reference):

  • General 10px
  • Notifications 24px
  • Preferences 20px
  • Keyboard 20px
  • Voice 10px
  • Security 10px
  • Labs 20px
  • Help & About 24px

Appearance tab will need a slightly different approach as it has a subtitle so is out of scope for this task.

(If this is your first element-web task, please note that you should test the changes before submitting the PR for review.)

The different tabs currently look like this when laid out next to each other: settings

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
dbkrcommented, Jan 31, 2022

There’s probably a broader scope of work that could be done here unifying all the dialogs into the same template & CSS, but I think we can fix this bug without doing that work by just tweaking the CSS in the the dialogs in react-sdk. This could be a good task for someone with CSS skills to get familiar with the codebase. @sahilsaini110 feel free to submit a PR for this if that sounds like something that would interest you.

1reaction
SimonBrandnercommented, Mar 2, 2022

I would like to work on this issue

Great! If you need any help/have any questions be sure to visit https://matrix.to/#/#element-dev:matrix.org!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Change the margins in your Word document - Microsoft Support
Apply a predefined margin setting. Select Layout > Margins. The Margins option is highlighted on the Layout tab. Select the margin measurements you...
Read more >
How to align content to the left and right on the same line in a ...
Click Tabs (near the bottom). In the resulting dialog, enter the position for the right margin, 6.5, and click Set. I chose 6.5...
Read more >
Setting Document Margins - Microsoft Word - LibGuides
Click on the Page Layout tab; Click on Margins to see a drop-down menu; Make sure Normal is selected.
Read more >
How to set Tabs and Margins Using the Ruler Bar in Word
This video shows you how to set your tabs and margins in Microsoft word using the ruler bar. For CPU Tech Writing.
Read more >
How to Adjust Bullet or Number List Indents in Microsoft Word
Go to the Home tab and click the arrow next to Multilevel List. Move to Change List Level and choose the level you...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found