DiffTools.TryFind method is confusing

The DiffTools.TryFind is a bit confusing.

Is the feature request related to a problem

Spot the issue:

// Add if not already there
if (!DiffTools.TryFind(name, out _))
{
    DiffTools.AddTool(name, ... );
}

The issue is here that:

• There is a overload of TryFind that searches by name: public static bool TryFind(DiffTool tool, out ResolvedTool? resolvedTool), while the other (with string parameter), searches by extension: public static bool TryFind(string extension, out ResolvedTool? tool)
• I expected that the TryFind method is consistent with the AddTool, where name is the first argument.

Describe the solution

There are multiple solutions, those could be technical or semantic breaking. See the "or"s below 😉

• Add TryFindByExtension(string extension, ...)
• Rename TryFind(DiffTool tool, ...) to TryFindByName(DiffTool tool, ...)
• Add TryFindByName(string name, ...)
• Make TryFind(string extension, ...) obsolete (breaking change!)
• Make TryFind(DiffTool tool, ...) obsolete (breaking change!)

Describe alternatives considered

• Instead of TryFind rename to TryFindTool etc for consistency with AddTool
• No obsolete but hard breaking change

Additional context

Current work around (ugly, need Equals? Needs dictionary lookup?):

// Add if not already there
if (!DiffTools.Resolved.Any(c => c.Name == name))
{
    DiffTools.AddTool(name, ... );
}

[SimonCropp]

i agree in principle. can u submit a PR with your changes. then we can iterate on that if necessary

[304NotModified]

–> https://github.com/VerifyTests/DiffEngine/pull/272