Add timeout option for signClient.request

Is your feature request related to a problem? Please describe.

The default timeout for request sign is 5 minutes in hard code way, but in some scenarios, we need to customize the timeout value. One possible scenario is the wallet sign is an async process and may take more than 5 minutes. It’s a better way to expose this option to Dapps.

Describe the solution you’d like

• add timeout option in params

  public request: IEngine["request"] = async <T>(params: EngineTypes.RequestParams) => {
    this.isInitialized();
    await this.isValidRequest(params);
    const { chainId, request, topic, timeout } = params;
    const id = await this.sendRequest(topic, "wc_sessionRequest", { request, chainId });
    const { done, resolve, reject } = createDelayedPromise<T>(timeout);
    this.events.once<"session_request">(engineEvent("session_request", id), ({ error, result }) => {
      if (error) reject(error);
      else resolve(result);
    });
    return await done();
  };

• support timeout option in createDelayedPromise

export function createDelayedPromise<T>(timeout?: number) {
  timeout = toMiliseconds(timeout || FIVE_MINUTES);

[bkrem]

Hi @junyulah,

So the team went over this suggestion and it looks like this will already be covered by an upcoming implementation change (optional expiry values for wc_sessionRequest) outlined in this PR: https://github.com/WalletConnect/walletconnect-docs/pull/315/files

This hasn’t been agreed yet, but the way this would likely be implemented in the JS SignClient is similar to what you suggested: an additional expiry/timeout parameter (presumably the duration in seconds) which the client then internally converts to a UNIX timestamp as outlined in the spec PR.

Please let us know if you see issues here from your side.

cc @ganchoradkov

[junyulah]

Hi @bkrem, thanks for the quick response. The follow-up question is a great question! Currently we haven’t go that far, we are still developing the wallet. For our first step, we are working with a partner team which is working on a Dapp, that Dapp will the set timeout to a longer time. Like you said, there are many options for our partner team to do, but sounds like using the metadata of our wallet to distinguish requests is a better solution, but up the timeout in general is also acceptable in our first step.

Very excited to hear your team will discuss this, hope to hear your conclusions soon.