ReferenceError: global is not defined in runtime

Describe the bug Error when executing the example code

SDK Version (if relevant) “@walletconnect/sign-client”: “2.1.3”, “typescript”: “^4.9.3”, “vite”: “^3.2.4”

To Reproduce Checkout branch global-is-not-defined of repo: https://github.com/smelnikov/walletconnect-sample

yarn install
npx vite

A runtime error appears:

Uncaught ReferenceError: global is not defined
    at localStorage.js:49:3
    at node_modules/localStorage/lib/localStorage.js (localStorage.js:54:1)
    at __require2 (@walletconnect_sign-client.js?v=a6844a88:18:50)
    at node_modules/@walletconnect/keyvaluestorage/dist/cjs/browser/index.js (index.ts:1:1)
    at __require2 (@walletconnect_sign-client.js?v=a6844a88:18:50)
    at index.js:1848:18

Expected behavior There are no errors in runtime.

[smelnikov]

@bkrem I solved this problem with define global variable during build https://github.com/smelnikov/walletconnect-sample/commit/a4e658ee2b6cfaa6b5de5447dacc54eff342267f

But it looks like this must be fixed at the top level of the library.

[bkrem]

Thanks for raising this and especially including a repro for it @smelnikov 💯

While https://github.com/WalletConnect/walletconnect-utils/pull/36 will fix this type of issue for the code we (WalletConnect) own, this seems to be a reference in the localStorage dependency.

Did some digging and found the global reference here: https://git.coolaj86.com/coolaj86/local-storage.js/src/branch/local-storage/lib/localStorage.js#L49

cc @ganchoradkov, not sure what the best move here is, but I suspect we either:

• Submit a patch to the localStorage lib (who knows if/when that gets merged)
• Fork it and patch ourselves so we own the code.
• Use a different localStorage lib (seems drastic for an env/global reference issue but maybe wise long term)