Redesign of `CodableTransaction` gas resolver
See original GitHub issueWithin 3.0.0 all tx methods, properties etc were combined within CodableTransaction
. This is quite rough decision and surely not the best one available.
Whilst there’s a room for improvement in many kinds, this issue focused on figuring out a good way to improve gas resolving related methods and properties.
So @janndriessen proposed to move resolver from within CodableTransaction
object type to Web3Provider
object, stating there it fits better.
This is good one, but to keep consistency within the lib we should to think as well about both tied to that resolvers parts of the library and the transaction sending pipeline itself.
Therefore I invite you folks to discuss the sending transaction as well as calling contract API pipeline design.
Issue Analytics
- State:
- Created a year ago
- Comments:12
Top Results From Across the Web
File a complaint involving a gas, electric, or water company
Having a problem with your gas, electric, or investor-owned water company? ... water company, you should contact the company to try and resolve...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@yaroslavyaroslav @JeneaVranceanu @mloit please see #645 for a first draft PR.
I like the idea. This would help
CodableTransaction
get clean and more simple (just a struct).Checked again that only
gasLimit
andnonce
policies actually use the transaction passed. So we could easily all do this in the resolver who already has the provider (as described in the outline above).