Transaction option is not applied to send translation.

There is a problem that the trasactionOptions cannot be used properly because of merge. In the Web3+ MutatingTransaction class, it is replaced by cleanedOptions. I want to know the reason. 2.6.5 library version. Estimategas for EIP1559 is excellent. However, transaction option is not applied to send translation.

var options = writeTransaction.transactionOptions
        options.nonce = .latest
        options.callOnBlock = .latest
        options.type = .eip1559
        options.maxFeePerGas = .manual(maxFee)
        options.maxPriorityFeePerGas = .manual(maxTip)

If you run sendTransactionPromise with the above options, maxFeePerGas and maxPriorityFeePerGas are ignored. There seems to be some problem when merge.

public func sendPromise(password: String = "web3swift", transactionOptions: TransactionOptions? = nil) -> Promise<TransactionSendingResult>{
    let queue = self.web3.requestDispatcher.queue
    return self.assemblePromise(transactionOptions: transactionOptions).then(on: queue) { transaction throws -> Promise<TransactionSendingResult> in
      let mergedOptions = self.transactionOptions.merge(transactionOptions)
      var cleanedOptions = TransactionOptions ()
      cleanedOptions.to = mergedOptions.to
      return self.web3.eth.sendTransactionPromise(transaction, transactionOptions: cleanedOptions, password: password)
    }
}

maxFeePerGas , maxPriorityFeePerGas, type, nonce all nil. Only from, to exists.

/// create a JSCON RPC Request object for the given transaction
/// - Parameters:
///   - method: RPC request method
///   - transaction: the thansaction to encode/send
///   - trasactionOptions: additional options for the transaction
/// - Returns: a JSCONRPCrequest object
static func createRequest(method: JSONRPCmethod, transaction: EthereumTransaction, transactionOptions: TransactionOptions?) -> JSONRPCrequest? {
   let onBlock = transactionOptions?.callOnBlock?.stringValue
   var request = JSONRPCrequest ()

   request.method = method
   let from = transactionOptions?.from
   quard var txParams = transaction.encodeAsDictionary(from: from) else { return nil }
   if method == .estimateGas || transactionOptions?.gasLimit == nil {
        txParams.gas = nil
   }
   var params = [txParams] as [Encodable]
   if method.requiredNumOfParameters == 2&& onBlock != nil {
      params.append( onBlock as Encodable )
   }
   let pars = JSONRPCparams(params: params)
   request.params = pars
   if !request.isValid { return nil }
   return request
}

Maybe there is a problem with this method, too.

[JeneaVranceanu]

@Kristenlike1234 Something that I didn’t take into account right away is that TransactionOptions is a struct and since struct in Swift is a value type this action will create absolutely different variable:

var options = writeTransaction.transactionOptions

Modifying options won’t change anything in writeTransaction.transactionOptions.

What you should do instead is change transactionOptions directly:

writeTransaction.transactionOptions.nonce = .latest
writeTransaction.transactionOptions.callOnBlock = .latest
writeTransaction.transactionOptions.type = .eip1559
writeTransaction.transactionOptions.maxFeePerGas = .manual(maxFee)
writeTransaction.transactionOptions.maxPriorityFeePerGas = .manual(maxTip)

If you prefer the way you do it with a new options variable then pass it into send or sendPromise functions like this:

var options = writeTransaction.transactionOptions
options.nonce = .latest
options.callOnBlock = .latest
options.type = .eip1559
options.maxFeePerGas = .manual(maxFee)
options.maxPriorityFeePerGas = .manual(maxTip)

writeTransaction.send(password: ..., transactionOptions: options)
// or
writeTransaction.sendPromise(password: ..., transactionOptions: options)

[JeneaVranceanu]

@Kristenlike1234 Try passing back your options into send or sendPromise and ping me with the result, please. If that won’t help we should look further. For now, I’ll switch to a different task.