Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

meta data bug

See original GitHub issue

Hi there,

version: 3.0.0-rc1

There is a nasty bug, which prevents metadata (e.g. info.meta) to be accessible inside formatter unless there is at least one splat along with meta data.

Reproducing this bug is simple:

// THIS IS THE EXAMPLE THAT DOESN’T WORK AS EXPECTED // If you try to log meta data, it will NOT work (u won’t be able to access info.meta inside formatter), // unless there is at least one ‘splat’ included. logger.info('my message', { reason: 'whatever', promise: 'whenever' });

// THIS EXAMPLE WORKS FINE // In order to properly log meta data along with ‘my message’ you are forced to include at least one splat. logger.info('my message%s', 'It needs one splat that i do not need', { reason: 'whatever', promise: 'whenever' }); https://github.com/winstonjs/winston/blob/3b6da2c00b24a90bb6c99f2ae69fa8302f9f03d9/lib/winston/logger.js#L173

line 173: const info = Object.assign({}, meta, { [LEVEL]: level, level, message: msg });

Should be changed to: const info = Object.assign({}, { [LEVEL]: level, level, message: msg, meta });

With this change ,info.meta is accessible inside formatter regardless if there are any ‘splats’ included or not and it is now also sorted properly if you do a console.log on the info object (same order with splats or without any splat).

Can someone please test this bug and if the ‘code fix’ looks good, please apply this patched code to the project.

Best regards, Jim