Demo Error & No Terminal in WebPage

Details

• Browser and browser version: Safari 13.0.5
• OS version: Raspbian Buster
• xterm.js version: Latest

Steps to reproduce

1. Clone repo
2. npm install
3. create lock file (per npm recommendation to fix vulnerabilities)
4. sudo node /demo/start.js results in:

App listening to http://127.0.0.1:3000
Hash: d524bfd516e0a9cc5acc
Version: webpack 4.41.6
Time: 10597ms
Built at: 02/22/2020 5:36:54 PM
           Asset      Size  Chunks             Chunk Names
client-bundle.js  60.5 KiB    main  [emitted]  main
Entrypoint main = client-bundle.js
[./client.ts] 13.6 KiB {main} [built] [8 errors]

ERROR in ./client.ts
Module not found: Error: Can't resolve '../addons/xterm-addon-attach/out/AttachAddon' in '/opt/ste
rling/ip-kvm-interface/testing/xterm.js/demo'
 @ ./client.ts 12:22-77


ERROR in ./client.ts
Module not found: Error: Can't resolve '../addons/xterm-addon-fit/out/FitAddon' in '/opt/sterling/
ip-kvm-interface/testing/xterm.js/demo'
 @ ./client.ts 13:19-68

ERROR in ./client.ts
Module not found: Error: Can't resolve '../addons/xterm-addon-search/out/SearchAddon' in '/opt/ste
rling/ip-kvm-interface/testing/xterm.js/demo'
 @ ./client.ts 14:22-77

ERROR in ./client.ts
Module not found: Error: Can't resolve '../addons/xterm-addon-serialize/out/SerializeAddon' in '/o
pt/sterling/ip-kvm-interface/testing/xterm.js/demo'
 @ ./client.ts 15:25-86

ERROR in ./client.ts
Module not found: Error: Can't resolve '../addons/xterm-addon-unicode11/out/Unicode11Addon' in '/o
pt/sterling/ip-kvm-interface/testing/xterm.js/demo'
 @ ./client.ts 18:25-86

ERROR in ./client.ts
Module not found: Error: Can't resolve '../addons/xterm-addon-web-links/out/WebLinksAddon' in '/op
t/sterling/ip-kvm-interface/testing/xterm.js/demo'
 @ ./client.ts 16:24-84

ERROR in ./client.ts
Module not found: Error: Can't resolve '../addons/xterm-addon-webgl/out/WebglAddon' in '/opt/sterl
ing/ip-kvm-interface/testing/xterm.js/demo'

 @ ./client.ts 17:21-74

ERROR in ./client.ts
Module not found: Error: Can't resolve '../out/public/Terminal' in '/opt/sterling/ip-kvm-interface
/testing/xterm.js/demo'
 @ ./client.ts 11:19-52

ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts
./client.ts
[tsl] ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts(11,26)
      TS2307: Cannot find module '../out/public/Terminal'.

ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts
./client.ts
[tsl] ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts(12,29)
      TS2307: Cannot find module '../addons/xterm-addon-attach/out/AttachAddon'.

ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts
./client.ts
[tsl] ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts(13,26)
      TS2307: Cannot find module '../addons/xterm-addon-fit/out/FitAddon'.

ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts
./client.ts
[tsl] ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts(14,45)
      TS2307: Cannot find module '../addons/xterm-addon-search/out/SearchAddon'.

ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts

./client.ts
[tsl] ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts(15,32)
      TS2307: Cannot find module '../addons/xterm-addon-serialize/out/SerializeAddon'.

ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts
./client.ts
[tsl] ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts(16,31)
      TS2307: Cannot find module '../addons/xterm-addon-web-links/out/WebLinksAddon'.

ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts
./client.ts
[tsl] ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts(17,28)
      TS2307: Cannot find module '../addons/xterm-addon-webgl/out/WebglAddon'.

ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts
./client.ts
[tsl] ERROR in /opt/sterling/ip-kvm-interface/testing/xterm.js/demo/client.ts(18,32)
      TS2307: Cannot find module '../addons/xterm-addon-unicode11/out/Unicode11Addon'.

And the following shown from http://127.0.0.1:3000 (accessed remotely from local network ip hence safari browser in safari)

[jerch]

@Tyriar For me even npm install does not work with master branch, it complains:

> tsc -b -w ./tsconfig.all.json --preserveWatchOutput

[3:48:24 PM] Starting compilation in watch mode...

node_modules/@types/ws/index.d.ts:44:39 - error TS2694: Namespace '"url"' has no exported member 'URL'.

44     constructor(address: string | url.URL, options?: WebSocket.ClientOptions);

yarn works as expected. Any clue why npm install struggles here? Lock file again?

Edit: With a downgrade to @types/ws@5.1.2 it works again. ~I see that we dont require that ourselves in package.json, so the issue is somewhere in express-ws. Still - why does TS even try to parse/compile anything from ws? Imho we only use ws in the demo in JS code, not TS code? Is our main tsconfig.json too broad?~ Oh well, we have it package.json, any clue why?

Edit2: The issue is the ^6.0.1 rule in package.json, which installs 6.0.4. Seems the types devs have made incompatible interface changes in a bug fix version jump 😞. With explicit installing 6.0.1 it works as well.

[Tyriar]

Let us know if you still have issues, think this is stale