question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Search does not expand selection left when appropriate

See original GitHub issue

Consider the following terminal buffer:

blah blah tt

Searching for “t” will select the second “t” (because of backwards search), doing an incremental search for “tt” will find no results:

image

We should cover this edge case where the only result is expanding the selection left. Additionally, if there were 2 results, the selection should be expanded left instead of going to the next one as it’s still technically the same match.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
kena0kicommented, Oct 13, 2020

@Tyriar I opened a PR #3125. Please review it when you have time.

0reactions
kena0kicommented, Oct 13, 2020

Sorry, I found L156-L161 is not unnecessary. We need to check whether the selection can expand to right or not first. Otherwise, the selection moves around each time words are input. buggy

I ended up simply changing search position to selection end after the first search. The final result is here. result

Read more comments on GitHub >

github_iconTop Results From Across the Web

I lost my "expand selection" option when sorting - Super User
As a workaround, you may try to Press Ctrl + A to choose all the region that you want to sort. Besides, if...
Read more >
Reader Question: Cannot select single cell, row, or column
Apparently, according to this Microsoft Answers entry, if you press the F8 key, you're toggled into something called Extend Selection Mode. This basically...
Read more >
How to Sort in Excel Rows or Columns Avoid Sort Problems
In the Sort Options dialog box, under Orientation, select Sort Left to Right. Click OK, to close the Options dialog box.
Read more >
Video: Advanced filter details - Microsoft Support
Training: You can use the Advanced Filter to create more powerful filters, such as filtering for unique records and using operators such as...
Read more >
Resize a table by adding or removing rows and columns
You can use the Resize command in Excel to add rows and columns to a table: ... select the range on the worksheet,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found