Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Render performance degradation from 3.0.2 to 3.7.0

See original GitHub issue

Update: This issue should be introduced between 3.3.0 and 3.4.0.

Originally reported at: https://github.com/tsl0922/ttyd/issues/126

Details

Browser and browser version: Chrome69.0.3497.81
OS version: macOS High Sierra 10.13.6
xterm.js version: 3.7.0

Steps to reproduce

Start the 3.7.0 demo.
Open the demo with chrome, and turn on the FPS meter.
Resize it to a larger size (155 cols / 40 rows).
Run: vtop (npm install -g vtop).
Press and hold the down arrow button.
Result: 4-14 PFS on 3.7.0 (not stable) and 30-35 FPS on 3.3.0 (stable).

It’s much smoother on 3.0.2 (ttyd 1.4.0) than 3.7.0 (ttyd 1.4.1).

Issue Analytics

State:
Created 5 years ago
Comments:20 (20 by maintainers)

Top GitHub Comments

1reaction

Tyriarcommented, Sep 12, 2018

I think I fixed it, I removed a bunch of the object/string overhead and drawing from an ImageBitmap seems to make the dynamic cache go down to around 3ms on average (from 7). PR probably tomorrow.

0reactions

jerchcommented, Sep 12, 2018

Wow nice 👍

Also chrome got much much better in drawing things to canvas since version >65, the difference here between electron v2 and the newer browser is really impressive (like 3-5x faster in my tests). Maybe its broken again with v69 (not yet tested, still v68 here)?

Top Results From Across the Web

Epic Sum Up - Lean Project Management for Jira Teams

Define a JQL query to exclude / include Containers from the Container Link selection · Expand / collapse the structure of the Container...

4.1.0

Drop repeated calls to setComposition with the same composition. Bugs Fixed. Fixed an image scaling issue. Fixed a crash when leaving a screen...

Dolby Atmos Renderer

This documentation covers installation steps, software changes, and known issues for Dolby Atmos. Renderer v3.7. •. About this documentation. •.

Chart.js

js-based, charting libraries that render as SVG. Canvas rendering makes Chart.js very performant, especially for large datasets and complex ...

Changelog — Aim 3.15.1 documentation

Fix AimLogger deprecation issues related to release of PyTorch Lightning v1.7 ... Improve rendering performance by enhancing table columns virtualization ...