Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Search addon: Support "find as you type"

See original GitHub issue

It would be nice to have a browser-style “find-as-you-type” logic. I think it would work if a couple functions were added:

findCurrentOrNext(needle)

findCurrentOrPrevious(needle)

These would expand the current selection if the needle is present at the 0-index of the current selection; otherwise they’d do a normal findNext or findPrevious.

Plan issue: #705

Issue Analytics

State:
Created 5 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

Tyriarcommented, Sep 21, 2018

This may just be a matter of starting the search at the current cursor position, rather than the next line (or at the end of the search term). In that case maybe this makes more sense as an option?

https://github.com/xtermjs/xterm.js/blob/005785b84df3b6e88059bee4da43f7a16db54180/src/addons/search/Interfaces.ts#L24-L28

0reactions

peacefullatomcommented, Sep 21, 2018

Yes, it makes sense. In case if user hits enter we perform regular search, in case if new symbol is readable we are updating the search term and reruning a whole routine. Now the goals are clear, thank you 😃