Can not add reverse socket connection

Issue Checklist

• I’m using the library programmatically

Library version

0.0.14

Runtime

Linux, Chrome Version 100.0.4896.127 (Official Build) (64-bit)

Device

DJI FPV goggles V2

Describe the bug

I am trying to add a reverse socket connection, basically what adb reverse tcp:0 tcp:6666 does:

const credentialStore = new AdbWebCredentialStore();
const device = await AdbWebUsbBackend.requestDevice();
const streams = await device.connect();
const adb = await Adb.authenticate(streams, credentialStore, undefined);
await adb.reverse.add("tcp:0", "tcp:6666", {
  onSocket: (packet, socket) => {
    //...
  }
});

Is resulting in this error:

Error: Stream ended
    at AdbBufferedStream.read (buffered.ts:49:1)

I could trace it till here, seems something fails during de-serialization: https://github.com/yume-chan/ya-webadb/blob/d0a8257a2dd7e315bc191565695c22330e588f7a/libraries/adb/src/commands/reverse.ts#L95

Steps to reproduce

const credentialStore = new AdbWebCredentialStore();
const device = await AdbWebUsbBackend.requestDevice();
const streams = await device.connect();
const adb = await Adb.authenticate(streams, credentialStore, undefined);
await adb.reverse.add("tcp:0", "tcp:6666", {
  onSocket: (packet, socket) => {
    //...
  }
});

[yume-chan]

Version 0.0.15 released with the compatibility fix for Android 7 (and older) and some API changes.

Here is an example, I only tested it on Android 9 because this device has netcat.

https://github.com/yume-chan/ya-webadb/blob/12f88c355c63a8fbfc677adef1c2a5c6675195cb/apps/demo/src/pages/reverse.tsx#L17-L31

The handler now needs to return true to accept the connection, otherwise the dispatcher will ask the next handler (if any) and ultimately reject it. No packet will arrive before return, and .pipeTo(new WritableStream()) is the most common method to handle a stream in Web Streams API.

The second parameter is now a string and it can be any value without null characters.

[yume-chan]

Glad to hear that!