spawn/spawnAndWait fails to open socket

Issue Checklist

• I’m using the library programmatically

Library version

0.0.13

Runtime

Linux, Chrome Version 100.0.4896.127 (Official Build) (64-bit)

Device

DJI FPV goggles V2

Describe the bug

When trying to spawn a process:

const device = await AdbWebUsbBackend.requestDevice();
const streams = await device.connect();
const adb = await Adb.authenticate(streams, credentialStore, undefined);
const result = await adb.subprocess.spawnAndWait(["ls"]);

I get the following error (same thing with spawn and spawnAndWaitLegacy):

Error: Socket open failed
    at AdbPacketDispatcher.handleClose (dispatcher.ts:129:1)
    at Object.write (dispatcher.ts:67:1)
    at g (webidl.ts:78:1)
    at S (webidl.ts:88:1)
    at Object.write (underlying-sink.ts:71:1)
    at WritableStreamDefaultController.i [as _writeAlgorithm] (writable-stream.ts:1114:1)
    at writable-stream.ts:544:1
    at Br (writable-stream.ts:1202:1)
    at writable-stream.ts:1171:1
    at Cr (writable-stream.ts:917:1)
    at Object._chunkSteps (pipe.ts:117:1)
    at G (default-reader.ts:51:1)
    at at (default-controller.ts:251:1)
    at ReadableStreamDefaultController.enqueue (default-controller.ts:91:1)
    at Object.pull (transform.ts:345:1)

This seems to be specific on my device, I tried with a phone and it works. Interestingly enough I can get a shell process no problem:

const device = await AdbWebUsbBackend.requestDevice();
const streams = await device.connect();
const adb = await Adb.authenticate(streams, credentialStore, undefined);
const socket = await adb.subprocess.shell();
const writer = socket.stdin.getWriter();
socket.stdout.pipeTo(new WritableStream({
  write: (chunk) => {
    console.log(decodeUtf8(chunk));
  }
}));

I would really love to be able to spawn a process though and get output and exit codes. Let me know which information you need to further debug this

Steps to reproduce

const device = await AdbWebUsbBackend.requestDevice();
const streams = await device.connect();
const adb = await Adb.authenticate(streams, credentialStore, undefined);
const result = await adb.subprocess.spawnAndWait(["ls"]);

[yume-chan]

Version 0.0.14 released with the fix.

[yume-chan]

Checked the source code of Android 6 and found out it doesn’t support the command format I use.

You can manually patch your node_modules/@yume-chan/adb/esm/commands/subprocess/protocols/none.js line 18 to give it a try.

- return new AdbSubprocessNoneProtocol(await adb.createSocket(`shell,raw:${command}`));
+ return new AdbSubprocessNoneProtocol(await adb.createSocket(`exec:${command}`));