events (advanced): Omit subscribers on subscription/add for certain clients.

This is an advanced bug that requires deep knowledge of our event system as well as the ability to coordinate with core project folks on API changes.

Fortunately, it’s a mostly harmless bug. (You can actually call it an unimplemented feature, to be fair.)

Right now we always send subscribers on the subscription/add event. Arguably API clients that register with include_subscribers=False don’t want that extra info on their payload. We should consider omitting subscribers for clients that don’t want subscriber info.

Since these events are only sent to the current user who is subscribing to a stream, the impact is probably minimal.

The fix here is somewhat non-trivial, as we would need to modify ClientDescriptor to track the appropriate flags. It’s actually a small change in terms of lines of code (I think), but it’s a pretty highly technical part of our system.

[showell]

I am closing this. I just don’t think it’s worth the trouble. We may consider similar solutions in the future if API client authors ask for this type of optimization.

[showell]

I guess we don’t have a low-priority label, so I added “difficult”.