question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Migrate modals and popovers from Django templates to Handlebars

See original GitHub issue

We have a bundle of small overlays, modals and popovers in templates/zerver/app that we should migrate to a handlebars template as part of #18792. This issue lays out the plan for doing so, in terms of new filenames (often clearer)

  • lightbox_overlay.html => lightbox_overlay.hbs. This should be straightforward as there are no conditionals; we just need to migrate translation tags.
  • index.html has the user_status_overlay, aka the right sidebar “set my status” overlay, embedded in it. We should extract that as set_status_overlay.hbs. This should be straightforward; we just need to migrate translation tags.
  • message_history.html. Accessible by hitting the “Show edit history” option in the message actions menu after editing a message. It’s a simple modal with just a “Close” button and migration should mostly just involve translation tag changes.
  • about-zulip.html => static/templates/about_zulip.hbs. Requires moving the two variables it uses to page_params from the context as discussed in #18792, but should be otherwise straightforward. Accessible in the gear menu as “About Zulip” for testing.
  • deprecation_notice.html => static/templates/deprecated_feature_notice.hbs. Should just require moving code and editing translation tags, but we might want to move the JavaScript code to deprecated_feature_notice.js and migrate the variable names in the same PR. Accessible by hitting the * or C hotkey.
  • invite_user.html => static/templates/invite_users.hbs. This one may be a bit involved of a migration, since we have various role data fields in here. @sahil839 would you be up for taking this one? (Feel free to grab any others as well).

I’d appreciate each of these migrations being independent small PRs (possibly with extra commits to clean up related variable names for consistency). So folks should claim individual items via comments here, not claiming the whole issue.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

2reactions
ganpa3commented, Jun 14, 2021

I am taking up invite users modal part.

Great. I will grab the rest.

1reaction
sahil839commented, Jun 11, 2021

I am taking up invite users modal part.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Work product description@GSoC-2021 - gists · GitHub
... modals to a separate folder. #18701: popovers: Migrate user status indicator tooltip to tippy. ... Migrating Django templates to handlebars:.
Read more >
Handlebars.js in Django templates - Stack Overflow
I'm having syntax conflicts with handlebars templates inside a django template because django tries to render handlebars variables.
Read more >
Django 1.8.8 Migrations first says nothing, then won't apply ...
I'm having two migration issues: I added a new file with two new classes (database tables). The tables are to be added to...
Read more >
Schema migrations — Zulip 7.0-dev+git documentation
This page documents some important issues related to writing schema migrations. If your database migration is just to reflect new fields in models.py...
Read more >
Modal - Bootstrap
Modals are built with HTML, CSS, and JavaScript. · Clicking on the modal “backdrop” will automatically close the modal. · Bootstrap only supports...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found