Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Re-check user settings before sending notifications.

See original GitHub issue

After #19246, we no longer have checks in email/push notification handlers for user settings as we did before. This is important especially for email notifications, which may be sent a long time after the message was sent, and there’s a chance the user modified their notification settings in the meantime.

A PR fixing this issue should share/extract as much code as possible with/from the get_recipient_info function in actions.py

Issue Analytics

State:
Created 2 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

timabbottcommented, Aug 1, 2021

I think it makes sense to do this in both code paths, for consistency. Even without the explicit delay we have with email notifications, push notifications can still be delayed up to 10 minutes given the queue garbage-collection code path, so if we think it’s correct to recheck settings, we should do it for both.

0reactions

abhijeetbodas2001commented, Sep 1, 2021

A PR for this should also follow-up on 24b1439e9333b25207758178cfa575b96f4c6314, and add checks for bots in the new rechecking system.