Current games issue

const nombre = args.slice([1]).join(' ');
const nombreUrl = nombre.replace(/\s/g, "%20").toLowerCase(); 
const summoner = await kayn.Summoner.by.name(nombre)
let game = await kayn.CurrentGame.by.summonerID(summoner.id) // awaiting doesn't solve it
console.log(typeof(game));

When trying to see the type of variable game if there is no current games for the Summoner, instead of the 404 object, the console returns an “Unhandled promise rejection” and I can’t reassign it nor see it’s type. Is this an issue or am I doing it wrong?

[cnguy]

Ohhh, I haven’t been reading carefully. you can try this:

const nombre = args.slice([1]).join(' ');
const nombreUrl = nombre.replace(/\s/g, "%20").toLowerCase();
let summoner = null;
try {
  summoner = await kayn.Summoner.by.name(nombre);
} catch (ex) {
  if (ex.statusCode == 404) game = null;
  else throw new Error("completely broken");
}
let game = null;
try {
  game = await kayn.CurrentGame.by.summonerID(summoner.id) // awaiting doesn't solve it
} catch (ex) {
  if (ex.statusCode == 404) game = null;
  else throw new Error("completely broken");
}
console.log(summoner, game)

Basically, if there’s a 404, just reassign null, otherwise if it’s some other error that mean something really bad happened (assuming retries are on), so just throw.

[cnguy]

If you place it inside the try block, the whole try statement will run from start-to-finish unless an error occurs. So you’ll be able to catch 404’s, 500’s, etc of both Summoner and CurrentGame. Not sure about the scoping part, but IMO if the logic is “combined”, then put it all in one try block.

I would put it in there personally, unless you want specific error-handling on a case-by-case basis.