Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rethink export and consumption of css vars

See original GitHub issue

Problem

How we export and consume css variables leaves a bit to be desired…

Current situation

@import '@commercetools-frontend/ui-kit/materials/colors/base-colors.mod.css';

Possible way forward

postcss-custom-media has introduced importFrom and exportTo` functionality.

For example, for base-colors.mod.css (which is already generated from JS), we could instead have these generated to a json file, and then use importFrom to consume them.

I would propose doing a bit of research into this and making a spike out of it.

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

montezumecommented, Oct 24, 2018

@dferber90 I think we have done everything. The only thing we didn’t deal with is exporting the media queries. There is a similar way with postcss-custom-media but I’m not sure if it’s worth the trouble. Would be nice to remove that need for V6 that @emmenko found though.

1reaction

tdeekenscommented, Oct 17, 2018

Nice idea. I’ve seen that somewhere that colors and variables in general where exported as JSON, JS and CSS variables.