Geonames Tools_pro.tbx/LoadGeonamesFile corrupt/not running in Pro

Something about the conversion process when converting the model from ArcMap to ArcPro is corrupting the Model Geonames Tools_pro.tbx/LoadGeonamesFile

The ArcMap model works fine unmodified in Pro but something about saving the model/toolbox in Pro is corrupting the model. Suggest we just use the ArcMap version in the repo and for the Pro template.

Problems noticed (after saving and running in Pro):

1. You can’t run the model because it won’t let you set the feature class parameter

2. You can no longer open parts of the model:

3. MakeFeatureLayer step of the model does not show the expression when opened

4. When run from the command line in test driver - you get a bit more info - again this appears to be an issue with the MakeFeatureLayer step (Note: same “ERROR 000816” as above):

test_load_geonames (geonames_tests.GeoNamesTestCase.GeoNamesTestCase)Traceback (most recent call last):
  File "C:\DefenseTemplates\Github\solutions-geoprocessing-toolbox\utils\test\geonames_tests\GeoNamesTestCase.py", line 88, in test_load_geonames
    countryCodes, adminCodes, featureCodes)
  File "C:\DefenseTemplates\Github\solutions-geoprocessing-toolbox\geonames\Geonames Tools_pro.tbx", line 86, in LoadGeonamesFile
     ' F u l l   A d d r e s s '   & l t ; N o n e & g t ;   V I S I B L E   N O N E 
  File "C:\DefenseTemplates\Github\solutions-geoprocessing-toolbox\geonames\Geonames Tools_pro.tbx", line 83, in LoadGeonamesFile
     C o u n t r y   C O U N T R Y N A M E 1   V I S I B L E   N O N E 
  File "C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\geoprocessing\_base.py", line 506, in <lambda>
    return lambda *args: val(*gp_fixargs(args, True))
arcgisscripting.ExecuteError: Failed to execute. Parameters are not valid.
ERROR 000816: The tool is not valid.

[csmoore]

@Dbarnes1 Thanks for tip - that version does work and also is about half the size of the corrupted one (285KB vs 470KB).

I would be curious to know how the corrupted one vs. good ones got created just so we could avoid this happening in future.

Note: the toolbox/deployment is slightly different (no “scripts” folder) - something to do with how Pro packages - But I’ll adjust this and make a PR with good _pro.tbx:

[mfunk]

Checked and merged.