Is the default `initDataTransform` identity function configuration intended?

👋 there. 😃

I’m working on converting our bespoke FairPlay implementation to work within 2.5.5.

While stepping through Shaka’s implementation I arrived at this code in drm_engine:

https://github.com/google/shaka-player/blob/c0e7a9b62a57f73ef26d511e3d40d2dd0f014cb6/lib/media/drm_engine.js#L1020-L1029

I read this as, if a client has not specified a playerConfiguration.drm.initDataTransform callback then the default implementation should be used.

But, it turns out Shaka has a default identity function setup in configuration:

https://github.com/google/shaka-player/blob/c0e7a9b62a57f73ef26d511e3d40d2dd0f014cb6/lib/util/player_configuration.js#L85

So, as a client, if I omit playerConfiguration.drm.initDataTransform than the default handling in drm_engine is ignored.

I want to believe the default impl in player_configuration is unintended based on the function | undefined documentation: https://shaka-player-demo.appspot.com/docs/api/shaka.extern.html#.PlayerConfiguration

Thanks for your feedback.

[TheModMaker]

Yes, either of those options should recursively reset all the DRM configurations. There is also a player.resetConfiguration() method you can use to reset all configurations to the default.

[mseeley]

Thank you very much @TheModMaker.